Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Add Optional coder #33019

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RustedBones
Copy link
Contributor

Add coder for java.util.Optional.
Implementation based on NullableCoder

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@RustedBones RustedBones force-pushed the java-optional-coder branch 3 times, most recently from 9795969 to 9f86450 Compare November 12, 2024 17:16
@RustedBones RustedBones force-pushed the java-optional-coder branch 3 times, most recently from 901aa6a to 1c0ce81 Compare November 26, 2024 17:16
@RustedBones
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant