Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolaceIO.Read: Make sure the messageReceiver is always initialized. #32964

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bzablocki
Copy link
Contributor

Addresses #32660

See the bug. A random connection drop can cause the receiver to disconnect. This fix makes sure we always reconnect when needed.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@bzablocki
Copy link
Contributor Author

cc @ppawel - it would be great if you could test this fix. Thanks!

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@bzablocki
Copy link
Contributor Author

Run Java PreCommit

@ppawel
Copy link

ppawel commented Nov 4, 2024

cc @ppawel - it would be great if you could test this fix. Thanks!

OK, I will try to test it and report back some time this week. Thanks for the fix.

@bzablocki
Copy link
Contributor Author

This will be obsolete if #32962 is merged.

@bzablocki bzablocki marked this pull request as draft November 29, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants