Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Update Python JDBC write transforms to support configuring the batch size #32891

Open
1 of 17 tasks
chamikaramj opened this issue Oct 21, 2024 · 7 comments
Open
1 of 17 tasks

Comments

@chamikaramj
Copy link
Contributor

What would you like to happen?

Currently batch size [1] is not one of the configurable parameters available to cross-language Python JDBC write transform [2][3]. Should be just a matter of wiring this similar to other properties there and adding a test.

Might also be covered by recent work related to auto-generating Python x-lang wrappers. cc: @ahmedabu98

[1]

public Write<T> withBatchSize(long batchSize) {

[2]
[3]

Issue Priority

Priority: 2 (default / most feature requests should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@mravi
Copy link
Contributor

mravi commented Nov 5, 2024

@chamikaramj Can I take this issue ?

@chamikaramj
Copy link
Contributor Author

Absolutely. Thank you for looking into this.

@mravi
Copy link
Contributor

mravi commented Nov 16, 2024

.take-issue

@mravi
Copy link
Contributor

mravi commented Nov 25, 2024

@chamikaramj ptal at the PR ! A qq on if I should extend the configuration for batch size to JDBC here that seem to be used by the YAML based pipeline ?

@ahmedabu98
Copy link
Contributor

I can take a look @mravi. Yes adding it to the SchemaTransform would be a good bonus!

@mravi
Copy link
Contributor

mravi commented Nov 26, 2024

I can take a look @mravi. Yes adding it to the SchemaTransform would be a good bonus!

Ack ! Will send out an updated PR today

@chamikaramj
Copy link
Contributor Author

Thanks Ravi and Ahmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants