Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GitHub Actions workflows to Flink 1.19 and remove 1.15 and 1.16 #32837

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

kennknowles
Copy link
Member

These changes need to happen before #32836 because the tests will pull their definitions from master branch.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@kennknowles kennknowles requested review from Abacn and je-ik October 17, 2024 12:58
@github-actions github-actions bot added the build label Oct 17, 2024
@kennknowles kennknowles mentioned this pull request Oct 17, 2024
3 tasks
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Oct 17, 2024

Thanks. This is a good start. Took a look there are multiple reference to flink 1.15 in current GHA:

image

@kennknowles
Copy link
Member Author

I got the rest of them, I think.

@kennknowles kennknowles changed the title Move portable Flink GitHub actions to Flink 1.19 Move GitHub Actions workflows to Flink 1.19 Oct 17, 2024
@kennknowles
Copy link
Member Author

I haven't used GHA configs deeply in a long time but maybe we can put this in a variable somewhere.

@kennknowles
Copy link
Member Author

I haven't used GHA configs deeply in a long time but maybe we can put this in a variable somewhere.

Ah, it looks like this may require talking to infra every time we change, so that isn't worth it. https://docs.github.com/en/enterprise-cloud@latest/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#defining-configuration-variables-for-multiple-workflows

@kennknowles kennknowles mentioned this pull request Oct 17, 2024
3 tasks
@kennknowles kennknowles changed the title Move GitHub Actions workflows to Flink 1.19 Move GitHub Actions workflows to Flink 1.19 and remove 1.15 Oct 17, 2024
@@ -14,7 +14,7 @@
},
"JavaTestProperties": {
"SUPPORTED_VERSIONS": ["8", "11", "17", "21"],
"FLINK_VERSIONS": ["1.15", "1.16", "1.17", "1.18", "1.19"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK yea we should be able to set a "latest" or "live" flink version here, or create a new section that isn't Java-only since Flink is used in many non-Java situations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that could be a follow up

@kennknowles kennknowles changed the title Move GitHub Actions workflows to Flink 1.19 and remove 1.15 Move GitHub Actions workflows to Flink 1.19 and remove 1.15 and 1.16 Oct 17, 2024
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just had one find

@kennknowles
Copy link
Member Author

Thanks!

@kennknowles kennknowles merged commit b6e0a44 into apache:master Oct 17, 2024
4 checks passed
@kennknowles kennknowles deleted the flink_1.15_workflows branch October 17, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants