-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GitHub Actions workflows to Flink 1.19 and remove 1.15 and 1.16 #32837
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
fc6401c
to
a664821
Compare
I got the rest of them, I think. |
I haven't used GHA configs deeply in a long time but maybe we can put this in a variable somewhere. |
Ah, it looks like this may require talking to infra every time we change, so that isn't worth it. https://docs.github.com/en/enterprise-cloud@latest/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#defining-configuration-variables-for-multiple-workflows |
@@ -14,7 +14,7 @@ | |||
}, | |||
"JavaTestProperties": { | |||
"SUPPORTED_VERSIONS": ["8", "11", "17", "21"], | |||
"FLINK_VERSIONS": ["1.15", "1.16", "1.17", "1.18", "1.19"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK yea we should be able to set a "latest" or "live" flink version here, or create a new section that isn't Java-only since Flink is used in many non-Java situations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that could be a follow up
d96482d
to
fb1a381
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, just had one find
Thanks! |
These changes need to happen before #32836 because the tests will pull their definitions from
master
branch.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.