-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGES.md to include streaming NPE issue #32793
base: release-2.57.0
Are you sure you want to change the base?
Conversation
apache#32566 for reference.
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
assign to next reviewer |
Co-authored-by: Jack McCluskey <[email protected]>
CHANGES.md
Outdated
@@ -151,6 +151,7 @@ | |||
|
|||
* The beam interactive runner does not correctly run on flink ([#31168](https://github.com/apache/beam/issues/31168)). | |||
* When using the Flink runner from Python, 1.17 is not supported and 1.12/13 do not work correctly. Support for 1.17 will be added in 2.57.0, and the ability to choose 1.12/13 will be cleaned up and fully removed in 2.57.0 as well ([#31168](https://github.com/apache/beam/issues/31168)). | |||
* Some streaming pipeline's coder may throw and surface a NullPointerException ([#32566](https://github.com/apache/beam/pull/32566)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
For streaming pipelines, exceptions thrown by KeyCoders may be followed by a NullPointerException.
I think it's the keycoder can you verify?
Reminder, please take a look at this pr: @jrmccluskey |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @jrmccluskey |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
|
Any movement on this? I've been waiting for a response to @m-trieu 's review comment Also it's worth including this in the master branch copy of CHANGES.md as well in a separate PR |
Reminder, please take a look at this pr: @jrmccluskey |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @jrmccluskey |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @jrmccluskey |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @jrmccluskey |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
|
#32566 for reference.
Will also update 2.58 and 2.90 accordingly.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.