Polish .with_exception_handling docstring #32739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning reviewers. If you would like to opt out of this review, comment R: @shunping for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
R: @jrmccluskey for final approval |
|
Bump |
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
* replace 'record' with 'input' and fix example * more tweaking
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
* replace 'record' with 'input' and fix example * more tweaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed up the
.with_exception_handling()docstring. The main issue is that the example didn't actually pipe the transform into anything, which was confusing when I and another user were looking at it.I also replaced "record" with "input". AFAICT, most of the Beam python docs don't refer to elements as "records".