-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blog] - Beam YAML protobuf blogpost #32735
Conversation
@brucearctor If you want to take a look and drop some comments if you see potential improvements |
I'll take a look. Responding quickly, and without taking much of a look yet [ nor being familiar with Beam's blog infra ] --> is there an 'easy' way to view how it renders? Besides reading the Markdown and text, it'd be good to visualize that it's fine. I'm just waking up, so it probably is standard markdown and my mind not fully awake yet. |
Assigning reviewers. If you would like to opt out of this review, comment R: @rszper for label website. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes, but otherwise, LGTM.
R: @liferoad for final approval |
cc @Polber |
Co-authored-by: Rebecca Szper <[email protected]>
@ffernandez92 and others -- to not let this PR rot, is there anything else need to be addressed? |
LGTM. Thanks a lot! |
A blog post explaining Beam YAML's streaming capabilities, showcasing how to handle Protobuf events.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.