Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] - Beam YAML protobuf blogpost #32735

Merged
merged 18 commits into from
Oct 23, 2024

Conversation

ffernandez92
Copy link
Contributor

A blog post explaining Beam YAML's streaming capabilities, showcasing how to handle Protobuf events.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@ffernandez92
Copy link
Contributor Author

@brucearctor If you want to take a look and drop some comments if you see potential improvements

@brucearctor
Copy link
Contributor

I'll take a look.

Responding quickly, and without taking much of a look yet [ nor being familiar with Beam's blog infra ] --> is there an 'easy' way to view how it renders? Besides reading the Markdown and text, it'd be good to visualize that it's fine. I'm just waking up, so it probably is standard markdown and my mind not fully awake yet.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @rszper for label website.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

website/www/site/content/en/blog/beam-yaml-proto.md Outdated Show resolved Hide resolved
website/www/site/content/en/blog/beam-yaml-proto.md Outdated Show resolved Hide resolved
website/www/site/content/en/blog/beam-yaml-proto.md Outdated Show resolved Hide resolved
website/www/site/content/en/blog/beam-yaml-proto.md Outdated Show resolved Hide resolved
website/www/site/content/en/blog/beam-yaml-proto.md Outdated Show resolved Hide resolved
website/www/site/content/en/blog/beam-yaml-proto.md Outdated Show resolved Hide resolved
website/www/site/content/en/blog/beam-yaml-proto.md Outdated Show resolved Hide resolved
website/www/site/content/en/blog/beam-yaml-proto.md Outdated Show resolved Hide resolved
website/www/site/content/en/blog/beam-yaml-proto.md Outdated Show resolved Hide resolved
website/www/site/content/en/blog/beam-yaml-proto.md Outdated Show resolved Hide resolved
@brucearctor brucearctor removed their request for review October 10, 2024 19:07
ffernandez92 and others added 12 commits October 11, 2024 13:47
Copy link
Contributor

@rszper rszper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, but otherwise, LGTM.

Copy link
Contributor

R: @liferoad for final approval

@liferoad
Copy link
Collaborator

cc @Polber

@brucearctor
Copy link
Contributor

@ffernandez92 and others -- to not let this PR rot, is there anything else need to be addressed?

@liferoad
Copy link
Collaborator

LGTM. Thanks a lot!

@liferoad liferoad merged commit d0206f5 into apache:master Oct 23, 2024
6 checks passed
@ffernandez92 ffernandez92 deleted the beam-yaml-proto-bp branch October 23, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants