Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-2.60.0] Cherry pick #32650 into the release branch #32707

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 8, 2024

  • Enforce a size limit on StringSetData

  • Make StringSetData set mutable. This avoids copy and create new ImutableSet every time

  • adjust warning log

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

* Enforce a size limit on StringSetData

* Make StringSetData set mutable. This avoids
  copy and create new ImutableSet every time

* adjust warning log
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit f61c8e1 into apache:release-2.60.0 Oct 9, 2024
104 checks passed
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.60.0@64854bb). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release-2.60.0   #32707   +/-   ##
=================================================
  Coverage                  ?   58.84%           
  Complexity                ?     3091           
=================================================
  Files                     ?     1130           
  Lines                     ?   174062           
  Branches                  ?     3312           
=================================================
  Hits                      ?   102429           
  Misses                    ?    68307           
  Partials                  ?     3326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants