KafkaIO SDF: Fetch end position for each topic-partition tuple in a background thread, reusing kafka consumers. #32558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sjvanrossum, would you mind taking a look at this draft PR? |
bzablocki
force-pushed
the
offset-consumers-background-thread-publish
branch
from
e4c54db to
9f8476d
Compare
…ackground thread, reusing consumers.
bzablocki
force-pushed
the
offset-consumers-background-thread-publish
branch
from
9f8476d to
6d9857b
Compare
bzablocki
changed the title
|
R: @sjvanrossum can I ask you for a review? |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Hi @sjvanrossum would you mind taking a look? |
|
@sjvanrossum I believe you're working on the same thing in a separate PR, is that right? |
|
@claudevdm I picked this up while @bzablocki was OoO and concluded that decoupling Kafka consumers from DoFns would be more efficient than caching a consumer per split. Those changes are available in draft at #32986. |
|
I will close this. The continuation is in @sjvanrossum's PR: #32986. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.