Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request][Java]:filesToStage should support the gcs file path #32531

Closed
1 of 17 tasks
liferoad opened this issue Sep 21, 2024 · 1 comment · Fixed by #33006
Closed
1 of 17 tasks

[Feature Request][Java]:filesToStage should support the gcs file path #32531

liferoad opened this issue Sep 21, 2024 · 1 comment · Fixed by #33006
Assignees
@liferoad
Labels
java new feature P2
Milestone
2.62.0 Release

Comments

@liferoad
Copy link
Collaborator

liferoad commented Sep 21, 2024 •
edited
Loading

What would you like to happen?

we should support the gcs file path not just local file path for sdks/java/core/src/main/java/org/apache/beam/sdk/options/FileStagingOptions.java

Issue Priority

Priority: 2 (default / most feature requests should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@liferoad liferoad self-assigned this Sep 21, 2024
@liferoad liferoad mentioned this issue Nov 2, 2024
Merged
3 tasks
@liferoad
Copy link
Collaborator Author

Notes about staging files:

https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java#L1217 --> https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java#L1208 -> https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java#L312

@github-actions github-actions bot added this to the 2.62.0 Release milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liferoad liferoad

Labels
java new feature P2
Projects
None yet
Milestone
2.62.0 Release
Development

Successfully merging a pull request may close this issue.

Added replaceGcsFilesWithLocalFiles liferoad/beam
1 participant
@liferoad