Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include jamm as runtime dependency in expansion-service #32521

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Sep 20, 2024

This PR allows a user to create a custom expansion service JAR without needing to provide jamm manually as a dependency.

e8cebdf added a dependency on ":sdks:java:harness" in the expansion service target which has a transitive dependency on a 'provided' jamm:

provided library.java.jamm

By adding it as a runtimeOnly dependency in the expansion service target, a user can create a cross-language Java transform by simply importing the beam-sdks-java-expansion-service JAR.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Polber
Copy link
Contributor Author

Polber commented Sep 20, 2024

R: @robertwb

@Polber
Copy link
Contributor Author

Polber commented Sep 20, 2024

R: @ahmedabu98

@github-actions github-actions bot added the java label Sep 20, 2024
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@ahmedabu98 ahmedabu98 merged commit bbf72c2 into apache:master Sep 20, 2024
23 checks passed
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants