Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove BQMS catalog until it is opend-sourced #32386

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

ahmedabu98
Copy link
Contributor

Downloading the BQMS dependency has been a little hacky and unusual for Beam and general open-source standards. We will wait until the catalog is open-sourced then include it in Beam again in a more proper way

@ahmedabu98
Copy link
Contributor Author

R: @chamikaramj

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@github-actions github-actions bot removed the python label Aug 30, 2024
@chamikaramj
Copy link
Contributor

Thanks. +1 for removing support for BQMS till the dependency is properly available.

LGTM.

@ahmedabu98 ahmedabu98 merged commit e18596c into apache:master Aug 31, 2024
32 checks passed
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.34%. Comparing base (511f294) to head (a7835d8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #32386   +/-   ##
=========================================
  Coverage     57.34%   57.34%           
  Complexity     1474     1474           
=========================================
  Files           964      964           
  Lines        153341   153341           
  Branches       1076     1076           
=========================================
  Hits          87927    87927           
  Misses        63215    63215           
  Partials       2199     2199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants