-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try deflaking test timing #32351
Try deflaking test timing #32351
Conversation
R: @Abacn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
…mccorm/ri_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick fix
feel free to merge after tests pass
it's still flaky: https://github.com/apache/beam/actions/runs/10624250387/job/29452206127 as it only happens on windows, we can revert this change and skip this test on windows os instead |
* Try deflaking test timing * Add another potential timeout * Simpler technique
* Revert "Try deflaking test timing (apache#32351)" This reverts commit 7d6f6fb. * Dont run flaky test on windows
As pointed out in #32237 (comment) this test can be flaky. This tests that after
20
is processed (and times out) and at least 10 (2*timeout) seconds have passed, that the model will be full deleted.Right now, it relies on timing and assumes that the pcollection will be processed in order (or at least the
20
will be processed early). This tries to deflake the test by adding some more elements which are guaranteed to timeout to ensure that after the first times out, sufficient time will pass for garbage collection to occur. It does admittedly lengthen the time to run to ~1 minute, unfortunately.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.