-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prism] Add an idle shutdown timout to prism binary. #32276
Conversation
R: @jrmccluskey |
This will end up being cherry picked into the release, along with an associated change to use them with the Java and Python runner wrappers. |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one docstring change
Co-authored-by: Jack McCluskey <[email protected]>
Thank you very much! |
* Add an idle shutdown timout to prism binary. * Correct flag text. Co-authored-by: Jack McCluskey <[email protected]> --------- Co-authored-by: lostluck <[email protected]> Co-authored-by: Jack McCluskey <[email protected]>
Adding a flag --idle_shutdown_timeout to avoid SDKs leaving dangling prism processes after a job terminates.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.