-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java11 Migration] Migrate Go testing to use Java11 container image for xlang #32212
Conversation
R: @Abacn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm also actively fixing tests. Let's do something like this:
So it always depend on current Java version
I went a slightly different direction to go with the same way we set the Flink version string, instead of making all the files do an import (which they don't do presently), and needing a side variable. Let's see if I did it right... |
Yeah this should work well. For the link above it was due to the file being "commons.gradle" instead of "build.gradle", where not explicitly applied (though all reference to "commons.gradle" called the plugin before) so I chose not to depend on project.ext initialized by apply : beamModulePlugin |
The default Xlang transforms got moved to Java 11, but we were only building the Java8 ones, so 11 wasn't available.
Move to use Java 11 to unbreak the existing tests.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.