Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prism] Support interval windows/prep for custom windows. #32121

Closed
Tracked by #29650
lostluck opened this issue Aug 8, 2024 · 0 comments · Fixed by #32180
Closed
Tracked by #29650

[prism] Support interval windows/prep for custom windows. #32121

lostluck opened this issue Aug 8, 2024 · 0 comments · Fixed by #32180
Assignees

Comments

@lostluck
Copy link
Contributor

lostluck commented Aug 8, 2024

In elementmanager.go triageTimers, we don't propagate the "kind" of window so we can't switch between global windows or interval window decoding. This is technically related to the coder-redesign used for timer decoding, preventing use of the existing window coders that rely on io.Readers.

This may also at least take into account custom windowfns (which are prefixed with their maxEventTime timestamp, but may also have arbitrary bytes afterwards depending on the coder), but this isn't a required case for this issue (as the element coder could be a "known coder" instead of merely being length prefixed. Must be handled when #31921 is handled.

Resolving this will allow the Python Validates Runner test test_windowed_pardo_state_timers to pass.

@lostluck lostluck self-assigned this Aug 8, 2024
lostluck added a commit to lostluck/beam that referenced this issue Aug 14, 2024
lostluck added a commit that referenced this issue Aug 15, 2024
* [#32121] Support timers in interval windows.

* fix test

---------

Co-authored-by: lostluck <[email protected]>
@github-actions github-actions bot added this to the 2.59.0 Release milestone Aug 15, 2024
reeba212 pushed a commit to reeba212/beam that referenced this issue Dec 4, 2024
* [apache#32121] Support timers in interval windows.

* fix test

---------

Co-authored-by: lostluck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant