-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JobServerOption for --jar_cache_dir
#32033
Conversation
Signed-off-by: s21.lee <[email protected]>
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! Overall, this looks like a good change to me, would you mind taking a look at the failing precommits and make sure the code is at least passing most of those and compiling? It looks like there are some issues with the test code
- add missing comma Signed-off-by: s21.lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
waiting on author |
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
Signed-off-by: s21lee <[email protected]>
@tvalentyn Hi, thank you for your help. |
I re-ran the tests, let's see if it still happens. |
The Workflow run is cancelling this PR. It is an earlier duplicate of 2083803 run. |
The Workflow run is cancelling this PR. It is an earlier duplicate of 1729654 run. |
LGTM |
Please add a meaningful description for your change here
Pass custom cache dir to prevent
PermissionError: [Errno 13] Permission denied: '/home/.apache_beam'
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.