[Dataflow Streaming Engine] Turn on --useWindmillIsolatedChannels and --useSeparateWindmillHeartbeatStreams by default
#31899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtbeatStreams` by default on streaming engine useWindmillIsolatedChannels: Each windmill grpc stream will use a separate underlying HTTP2 connection useSeparateWindmillHeartbeatStreams: Separate windmill GetData streams will be used for heartbeats and key data requests If required the features can be turned off using `--useWindmillIsolatedChannels=false` and `--useSeparateWindmillHeartbeatStreams=false`
|
R: @scwhittle |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Pending ongoing discussions internally on how to deploy |
|
Closing as this is being done with new job setting path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on
--useWindmillIsolatedChannelsand--useSeparateWindmillHeartbeatStreamsby default on streaming engineuseWindmillIsolatedChannels: Each windmill grpc stream will use a separate
underlying HTTP2 connection
useSeparateWindmillHeartbeatStreams: Separate windmill GetData streams
will be used for heartbeats and key data requests
If required the features can be turned off by passing
--useWindmillIsolatedChannels=falseand--useSeparateWindmillHeartbeatStreams=false