Allow compression of Elasticsearch requests #31601
Conversation
Amar3tto
force-pushed
the
elasticsearch-compression
branch
2 times, most recently
from
cb2bb9d to
2bd97f0
Compare
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
R: @johnjcasey |
| @@ -717,6 +738,7 @@ RestClient createClient() throws IOException { | |||
| Header[] headerList = new Header[getDefaultHeaders().size()]; | |||
| restClientBuilder.setDefaultHeaders(getDefaultHeaders().toArray(headerList)); | |||
| } | |||
| restClientBuilder.setCompressionEnabled(isCompressionEnabled()); | |||
There was a problem hiding this comment.
I am thinking about whether we need to put setCompressionEnabled invocation in a branch in case user is still on old version of elasticsearch client
if (isCompressionEnabled()) {
restClientBuilder.setCompressionEnabled(true);
}
There was a problem hiding this comment.
We can do it just in case
| @@ -27,7 +27,7 @@ enableJavaPerformanceTesting() | |||
| description = "Apache Beam :: SDKs :: Java :: IO :: Elasticsearch-Tests :: 7.x" | |||
| ext.summary = "Tests of ElasticsearchIO on Elasticsearch 7.x" | |||
|
|
|||
| def elastic_search_version = "7.13.4" | |||
| def elastic_search_version = "7.17.22" | |||
There was a problem hiding this comment.
The current change should make elasticsearch-test-5 and 6 to fail, however it is not the case, and I found the elasticsearch compatibility tests never configured to use intended client version, e.g.
+--- org.elasticsearch.client:elasticsearch-rest-client:6.4.0 -> 7.9.2 (*)
There was a problem hiding this comment.
Yes, so I preferred not to change anything related to 5 and 6 in this PR
There was a problem hiding this comment.
agree. Fix elasticsearch compatibility test to use intended client version could be a followup. If infeasible to support lower versions (5, 6) we can remove those test projects as they are already eol
Amar3tto
force-pushed
the
elasticsearch-compression
branch
from
2bd97f0 to
5daf234
Compare
Fixes #30641
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.