[Prism] Terminate Job with CancelFn instead of panic #31599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @lostluck |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
lostluck
reviewed
Jun 14, 2024
| @@ -22,6 +22,7 @@ import ( | |||
| "container/heap" | |||
| "context" | |||
| "fmt" | |||
| "github.com/apache/beam/sdks/v2/go/pkg/beam/internal/errors" | |||
There was a problem hiding this comment.
This import is in the wrong group. Please put it in the group with the other sdk imports, not the standard library imports.
There was a problem hiding this comment.
I'm so embarrassed. I'll fix it.
lostluck
approved these changes
Jun 14, 2024
|
I wasn't successful creating a test case that simulates the behavior. I suspect as we fix other unsupported features, we might be able to reveal more what is going on. It's only one Java Test class and only one is it's methods. In the grand scheme of things, I'm ok moving on for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #31338, refactoring
engine.ElementManagerBundlesmethod to receive acontext.CancelCauseFuncso that the Job fails instead of panic. This allows us to associate failing validation tests with stuck jobs.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.