-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherrypick #31550 and #31602 onto release branch #31562
Cherrypick #31550 and #31602 onto release branch #31562
Conversation
R: @kennknowles |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will merge when green
This may be red on the release branch:
|
right. I think that has been fixed in master recently but needs to be cherry-picked as well. 47d9bca |
it will make me happy if you will rebase so it can be green for sure (yes, I know it is very obvious and we are confident what the problem was) |
…ucket has soft delete enabled (apache#31550) * Add warning if soft delete is enabled in temp or staging buckets.
24553d9
to
51683bf
Compare
Tests are alll green now. |
@kennknowles Could you help to merge this? |
This PR is causing certain internal test failure. If you have not merged that, please skip it for this release (2.57.0). |
I can cp both. There is time. go ahead and open the other one to cherrypick as well |
The fix PR depends on the previous change. It may be easier to put both into one. |
Run Python PreCommit 3.11 |
Cherry-pick #31550 and #31602 onto release branch
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.