Solace Read connector: integration tests with testcontainers #31543
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
bzablocki
force-pushed
the
solace-connector-5-it
branch
from
ee96d70 to
28f687a
Compare
bzablocki
force-pushed
the
solace-connector-5-it
branch
from
28f687a to
94e1876
Compare
|
Run Java PreCommit |
|
Assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
sdks/java/io/solace/src/test/java/org/apache/beam/sdk/io/solace/it/SolaceContainerManager.java
Outdated
Show resolved
Hide resolved
sdks/java/io/solace/src/test/java/org/apache/beam/sdk/io/solace/it/SolaceContainerManager.java
Outdated
Show resolved
Hide resolved
| String queueName = "test_queue"; | ||
| solaceContainerManager.createQueueWithSubscriptionTopic(queueName); | ||
|
|
||
| // todo this is very slow, needs to be replaced with the SolaceIO.write connector. |
There was a problem hiding this comment.
Why is this slow? if its because of syncronous work, you could spin up a parallel thread pool
There was a problem hiding this comment.
What I actually meant here is that this method may not be ideal for performance testing with a large number of messages, as it might prove too slow. Parallelization for thousands of messages would likely offer too little improvement. For performance testing we need the write connector, which will come later.
For the current use case with 20 messages, inserting messages takes 2-second processing time on my machine. However, considering the overall Testcontainers setup time, this delay is relatively minor. WDYT?
bzablocki
force-pushed
the
solace-connector-5-it
branch
from
94e1876 to
80d04b7
Compare
bzablocki
force-pushed
the
solace-connector-5-it
branch
from
80d04b7 to
d2912c4
Compare
…31543) * Add integration tests * Use random exposed ports for testcontainers * Add info flag to gradle integrationTest command for extensive info
…31543) * Add integration tests * Use random exposed ports for testcontainers * Add info flag to gradle integrationTest command for extensive info
The PR for the Solace Read connector (addresses #31440).
The files that are relevant in this PR (only the last commit):
Other modified files in this pr are included in PRs that this one depends on.
This PR implements a basic integration test with testcontainers. It can be improved with the Write connector, once that is submitted and merged.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.