Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29902 finalize checkpoints after checkpoint #30971

Merged

Conversation

je-ik
Copy link
Contributor

@je-ik je-ik commented Apr 15, 2024

Fixes #29902
Fixes #30539

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@je-ik je-ik changed the title 29902 finalize checkpoints after checkpoint #29902 finalize checkpoints after checkpoint Apr 15, 2024
@je-ik
Copy link
Contributor Author

je-ik commented Apr 15, 2024

R: @Abacn
This would be best to rebase on master after merge of #30969, as one builds on the other.

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@je-ik je-ik force-pushed the 29902-finalize-checkpoints-after-checkpoint branch from 448640a to 2f38932 Compare April 15, 2024 17:35
@je-ik
Copy link
Contributor Author

je-ik commented Apr 15, 2024

Rebased this on top of master.

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@je-ik je-ik merged commit f41f364 into apache:master Apr 15, 2024
22 checks passed
@je-ik je-ik deleted the 29902-finalize-checkpoints-after-checkpoint branch April 15, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants