Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Add feast feature store handler for enrichment transform #30957

Merged
merged 10 commits into from
Apr 26, 2024

Conversation

riteshghorse
Copy link
Contributor

@riteshghorse riteshghorse commented Apr 12, 2024

Implement Feast feature store handler for enrichment transform. To setup the feast repository for GCP, see this notebook.

Example usage:

handler = FeastFeatureStoreEnrichmentHandler(
        entity_id='user_id',
        feature_store_yaml_path=<GCS_PATH>,
        feature_service_name=<service_name_used_while_deployment>,
)

with beam.Pipeline() as p:
  output = (
                  p
                  ....
                  | "Enrich with Feast" >> Enrichment(handler)
                  ....
  )

Fixes #30964


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@riteshghorse riteshghorse marked this pull request as ready for review April 15, 2024 13:34
@riteshghorse
Copy link
Contributor Author

Feast integration tests passed
image

Unrelated failures in other test suites

@riteshghorse
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions bot added build and removed build labels Apr 16, 2024
@github-actions github-actions bot added build and removed build labels Apr 18, 2024
@riteshghorse
Copy link
Contributor Author

Friendly ping!

@riteshghorse
Copy link
Contributor Author

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good, had a few comments

@riteshghorse
Copy link
Contributor Author

Feast tests passing-

image

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just had one last small comment about the pydoc, otherwise LGTM

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once checks pass - thanks!

@riteshghorse
Copy link
Contributor Author

Unrelated failures in postcommit with pytorch and tensorflow. Merging this one!
Thanks for the review!

@riteshghorse riteshghorse merged commit 3329edb into apache:master Apr 26, 2024
75 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Implement Feast feature store handler for Enrichment transform
2 participants