Change ManagedSchemaTransformProvider to take a Row config #30937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Java IO precommit failing due to #30941 |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Actually, I don't think this is possible because we don't know the underlying transform's configuration schema ahead of time. Even if we do via some mapping, this still won't work because configuration schemas differ from one IO to another |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small implementation detail change to make
ManagedSchemaTransformProvidertake a config represented as a Row instead of a YAML string. It makes more sense for xlang use-cases to send a Beam Row to configure the underlying transform rather than an inline Yaml string.This PR makes no changes to the surface-level Managed Java API