Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup iceberg GitHub Action workflow #30935

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fixup iceberg GitHub Action workflow #30935

merged 1 commit into from
Apr 11, 2024

Conversation

kennknowles
Copy link
Member

There was an interpolation variable incidentally left in it when I forked from another file.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Apr 11, 2024
@Abacn
Copy link
Contributor

Abacn commented Apr 11, 2024

Let's also add this workflow to https://github.com/apache/beam/blob/master/.github/workflows/README.md so there is an eye on the status of it

I would suggest keep the naming convention (beam_PreCommit_Java_Iceberg_IO_Direct.yml). The naming was inherited from Jenkins job names. I understand it may be verbose and not ideal, but until we get it all clean up let's keep this convention

@@ -71,8 +71,7 @@ jobs:
github.event_name == 'push' ||
github.event_name == 'pull_request_target' ||
(github.event_name == 'schedule' && github.repository == 'apache/beam') ||
github.event_name == 'workflow_dispatch' ||
github.event.comment.body == 'Run Java_Amqp_IO_Direct PreCommit'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep this. The phrase trigger for PreCommit is currently working

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@kennknowles
Copy link
Member Author

kennknowles commented Apr 11, 2024

https://github.com/apache/beam/actions/runs/8650999727/job/23720718775 shows that it works and finds a problem in the module (so this PR should be merged)

@kennknowles kennknowles merged commit 983f4e8 into master Apr 11, 2024
6 of 7 checks passed
@kennknowles kennknowles deleted the iceberg-gha branch April 11, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants