-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup iceberg GitHub Action workflow #30935
Conversation
Let's also add this workflow to https://github.com/apache/beam/blob/master/.github/workflows/README.md so there is an eye on the status of it I would suggest keep the naming convention (beam_PreCommit_Java_Iceberg_IO_Direct.yml). The naming was inherited from Jenkins job names. I understand it may be verbose and not ideal, but until we get it all clean up let's keep this convention |
@@ -71,8 +71,7 @@ jobs: | |||
github.event_name == 'push' || | |||
github.event_name == 'pull_request_target' || | |||
(github.event_name == 'schedule' && github.repository == 'apache/beam') || | |||
github.event_name == 'workflow_dispatch' || | |||
github.event.comment.body == 'Run Java_Amqp_IO_Direct PreCommit' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep this. The phrase trigger for PreCommit is currently working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
0365ee7
to
153c7db
Compare
https://github.com/apache/beam/actions/runs/8650999727/job/23720718775 shows that it works and finds a problem in the module (so this PR should be merged) |
There was an interpolation variable incidentally left in it when I forked from another file.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.