Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a bound on pydantic to exclude incompatible versions in the compat test. #30863

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

tvalentyn
Copy link
Contributor

fixes: #30852


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn tvalentyn changed the title Add a lower bound on pydantic Adds a bound on pydantic to exclude incompatible versions in the compat test. Apr 4, 2024
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like other suites are failing, do we need the same change for those? https://github.com/apache/beam/actions/runs/8562842465/job/23466866257?pr=30863

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Apr 5, 2024

Yes, we need to help dependency resolver to set correct constraints, taking a look. Those suites have a slightly different error:

4361 2024-04-05T00:36:50.9531130Z pip 24.0 from /runner/_work/beam/beam/sdks/python/test-suites/tox/py38/build/srcs/sdks/python/target/.tox-py38-TFHubEmbeddings-015/py38-TFHubEmbeddings-015/lib/python3.8/site-packages/pip (python 3.8)
4362 2024-04-05T00:36:51.0529237Z py38-TFHubEmbeddings-015: commands_pre[2]> pip check
4363 2024-04-05T00:36:52.5529107Z tensorflow 2.13.1 has requirement typing-extensions<4.6.0,>=3.6.6, but you have typing-extensions 4.11.0rc1.
4364 2024-04-05T00:36:52.5531012Z py38-TFHubEmbeddings-015: exit 1 (1.55 seconds) /runner/_work/beam/beam/sdks/python/test-suites/tox/py38/build/srcs/sdks/python> pip check pid=62176

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.53%. Comparing base (0d41168) to head (8145503).
Report is 65 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #30863       +/-   ##
=============================================
+ Coverage     56.86%   71.53%   +14.67%     
  Complexity     1485     1485               
=============================================
  Files           501      905      +404     
  Lines         46219   113065    +66846     
  Branches       1076     1076               
=============================================
+ Hits          26283    80884    +54601     
- Misses        17918    30163    +12245     
  Partials       2018     2018               
Flag Coverage Δ
python 81.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvalentyn tvalentyn merged commit 4452a6c into apache:master Apr 5, 2024
73 checks passed
@tvalentyn tvalentyn deleted the pydantic branch April 5, 2024 23:43
@Abacn
Copy link
Contributor

Abacn commented Apr 9, 2024

Python Coverage PreCommit is fixed however https://github.com/apache/beam/actions/workflows/beam_PostCommit_Python_Dependency.yml?query=event%3Aschedule is still failing. Does the same fix applicable to there?

@tvalentyn
Copy link
Contributor Author

sent #30907 , which might help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants