-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flink] finalize checkpoint marks in the new Flink source implementation #30849
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @johnjcasey added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
checked that if revert the change, the added unit test failed with
anyone able to confirm this has fixed the issue? CC: @anartemp @gfalcone @noster-dev |
Reminder, please take a look at this pr: @johnjcasey |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30849 +/- ##
=========================================
Coverage 71.27% 71.27%
Complexity 1485 1485
=========================================
Files 904 904
Lines 112898 112898
Branches 1076 1076
=========================================
Hits 80471 80471
Misses 30408 30408
Partials 2019 2019 ☔ View full report in Codecov by Sentry. |
Ah, I missed this before #30971 was merged. I'll try to consolidate the two PRs. |
…ion (#30849) (#30987) Co-authored-by: jto <[email protected]>
Closing in favor of #30987. |
This PR re-implements checkpoint marks finalization after is was accidentally removed in #28614
Fixes #30539 and fixes #29902
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.