Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flink] finalize checkpoint marks in the new Flink source implementation #30849

Closed
wants to merge 1 commit into from

Conversation

jto
Copy link
Contributor

@jto jto commented Apr 4, 2024

This PR re-implements checkpoint marks finalization after is was accidentally removed in #28614
Fixes #30539 and fixes #29902


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @johnjcasey added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Apr 5, 2024

checked that if revert the change, the added unit test failed with

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
	at org.apache.beam.runners.flink.translation.wrappers.streaming.io.source.unbounded.FlinkUnboundedSourceReaderTest.testCheckMarksFinalized(FlinkUnboundedSourceReaderTest.java:306)

anyone able to confirm this has fixed the issue? CC: @anartemp @gfalcone @noster-dev

Copy link
Contributor

Reminder, please take a look at this pr: @johnjcasey

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.27%. Comparing base (c44b454) to head (280aadd).
Report is 131 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #30849   +/-   ##
=========================================
  Coverage     71.27%   71.27%           
  Complexity     1485     1485           
=========================================
  Files           904      904           
  Lines        112898   112898           
  Branches       1076     1076           
=========================================
  Hits          80471    80471           
  Misses        30408    30408           
  Partials       2019     2019           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@je-ik
Copy link
Contributor

je-ik commented Apr 15, 2024

Ah, I missed this before #30971 was merged. I'll try to consolidate the two PRs.

@je-ik
Copy link
Contributor

je-ik commented Apr 17, 2024

Closing in favor of #30987.

@je-ik je-ik closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants