Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #30533: Automatically execute unbounded pipelines in streaming mode. #30706

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

damondouglas
Copy link
Contributor

This reverts commit 1c55117.

This commit has been associated with failures related to data sampling in Dataflow.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • N/A internal: Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas damondouglas marked this pull request as ready for review March 21, 2024 22:40
@damondouglas damondouglas requested a review from damccorm March 21, 2024 22:40
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@riteshghorse
Copy link
Contributor

Do we have any issue tracking this or failure run we can link?

@damccorm
Copy link
Contributor

My understanding is that this has caused some Dataflow tests to fail, but has it actually had negative impact on real pipelines? Is the problem here or is it with the tests themselves?

FYI @robertwb

@damondouglas damondouglas merged commit e207a14 into apache:master Mar 22, 2024
72 checks passed
@damondouglas damondouglas deleted the rollback-30533 branch March 22, 2024 16:43
hjtran pushed a commit to hjtran/beam that referenced this pull request Apr 4, 2024
@kennknowles
Copy link
Member

The description is not accurate - we have an underlying bug in dataflow and some erroneous tests. The original commit was a correct change. This is reverted while we fix our tests and service.

@kennknowles
Copy link
Member

kennknowles commented Apr 9, 2024

The tests are entirely internal to Google so there is no externally tracked failure. You would have to write a pipeline with unbounded data and then insist on running it in batch mode, which presumably not many people do since it has undefined/arbitrarily wrong behavior.

robertwb added a commit to robertwb/incubator-beam that referenced this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants