-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #30533: Automatically execute unbounded pipelines in streaming mode. #30706
Conversation
…eaming mode. (apache#30533)" This reverts commit 1c55117.
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Do we have any issue tracking this or failure run we can link? |
My understanding is that this has caused some Dataflow tests to fail, but has it actually had negative impact on real pipelines? Is the problem here or is it with the tests themselves? FYI @robertwb |
…eaming mode. (apache#30533)" (apache#30706) This reverts commit 1c55117.
The description is not accurate - we have an underlying bug in dataflow and some erroneous tests. The original commit was a correct change. This is reverted while we fix our tests and service. |
The tests are entirely internal to Google so there is no externally tracked failure. You would have to write a pipeline with unbounded data and then insist on running it in batch mode, which presumably not many people do since it has undefined/arbitrarily wrong behavior. |
…reaming mode. (apache#30533)" (apache#30706) This reverts commit e207a14.
This reverts commit 1c55117.
This commit has been associated with failures related to data sampling in Dataflow.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
Mention the appropriate issue in your description (for example:addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.