Fix io-gcp requiring hamcrest dependency

[Abacn]

Fix #30617

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[Abacn]

The failed PostCommit tests are either due to #30560 or quota error (failed to bring 1 worker)

R: @ahmedabu98 @kennknowles

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

[ahmedabu98]

Can we trigger BQ early rollout tests here?

beam/.github/workflows/beam_PostCommit_Java_BigQueryEarlyRollout.yml

Line 24 in 4ad189d

paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_BigQueryEarlyRollout.json']

[ahmedabu98]

Also would it make sense to combine TestBigQueryOptions and BigtableChangeStreamTestOptions in a new test/.../gcp/common/TestGcpIoPipelineOptionsRegistrar? instead of having them in separate registrars

[kennknowles]

These are options for TestBigQuery which is intended for users. Anything intended for users should be under src/main

[Abacn]

TestBigQueryOptions is still in main. The problem here is there is an AutoService to register TestBigQueryOptions, then whenever a PipelineOptionFactory.fromArgs is called, the PipelineOptionFactory tries to do some reflection access to TestBigQueryOptions which causes NoClassDefFoundError: org/hamcrest/Matcher. This is because TestPipelineOptions has a method return a Matcher.

This makes org.hamcrest effectively a required dependency (instead of optional one) for Beam io-gcp.

If do not register TestBigQueryOptions, users can still use it. They just need to register the option before they call PipelineOptionFactory.withValidation().

[Abacn]

An alternative fix will just be make it a implementation dependency here:

beam/sdks/java/io/google-cloud-platform/build.gradle

Line 119 in da26f5a

provided library.java.hamcrest

[kennknowles]

Yes, making it an implementation dependency seems correct. It is, after all, an implementation dependency :-)

[kennknowles]

hamcrest is a tiny tiny library that is super stable and has no transitive deps and not going to have security concerns - there is no reason to avoid it

[Abacn]

thanks, opened #30635 and close this PR

[kennknowles]

I know it could seem like anything "for testing" goes under src/test and should not be in the classpath, but that is not quite true. The only things that go in src/test or test dependency scope are things that are part of the test suite. Nothing should ever depend on the test scope artifact, so we shouldn't put anything in it that we want to distribute.