Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc Bug]: fileio.ReadAll() on integration test #30004

Closed
2 of 16 tasks
svetakvsundhar opened this issue Jan 12, 2024 · 2 comments · Fixed by #30008
Closed
2 of 16 tasks

[Doc Bug]: fileio.ReadAll() on integration test #30004

svetakvsundhar opened this issue Jan 12, 2024 · 2 comments · Fixed by #30008

Comments

@svetakvsundhar
Copy link
Contributor

What happened?

I am working to create more granular integration tests for dicomio.py and came across the example listed here: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/healthcare/dicomio.py#L96

This is outdated as fileio doesnt have the ReadAll() method. What would be the recommended and updated version of this example, given the recent GCS IO migration?

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@svetakvsundhar
Copy link
Contributor Author

cc: @shunping , @Abacn

@Abacn
Copy link
Contributor

Abacn commented Jan 12, 2024

GcsIO migration should not change any beam API and user faced transform. fileio.ReadAll() seems never existed. Checked that at the commit of this comment first introduced: https://github.com/apache/beam/blob/b87bb64a44c40114779b05ab742b91cbc20e2754/sdks/python/apache_beam/io/fileio.py I did not see fileio.readAll

There exists textio.ReadAllFromText though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants