Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Regression or Improvement: sideinpts_python_batch_1gb_1kb_10workers_1000window_1key_percent_dict:runtime #29943

Closed
github-actions bot opened this issue Jan 6, 2024 · 2 comments
Labels
awaiting triage perf-alert Automatically filed performance-related alerts.

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2024

Performance change found in the
test: sideinpts_python_batch_1gb_1kb_10workers_1000window_1key_percent_dict for the metric: runtime.

For more information on how to triage the alerts, please look at
Triage performance alert issues section of the README.

Test description: python | Side Input | 1 GB dictionary, 1% of keys, 1000 fixed windows
Test Link -

name: '1gb-1kb-10workers-1000window-1key-percent-dict',

Test Dashboard - http://metrics.beam.apache.org/d/-E9aGlFGk/side-input-load-tests?orgId=1&from=now-90d&to=now&viewPanel=8


timestamp: Sat Jan  6 18:15:27 2024, metric_value: 100.00
timestamp: Fri Jan  5 18:34:45 2024, metric_value: 138.00
timestamp: Thu Jan  4 18:24:31 2024, metric_value: 580.00 <---- Anomaly
timestamp: Wed Jan  3 18:21:10 2024, metric_value: 92.00
timestamp: Tue Jan  2 18:19:11 2024, metric_value: 102.00
timestamp: Mon Jan  1 18:16:00 2024, metric_value: 82.00
timestamp: Sun Dec 31 18:14:10 2023, metric_value: 99.00
timestamp: Sat Dec 30 18:13:33 2023, metric_value: 105.00
timestamp: Fri Dec 29 18:31:15 2023, metric_value: 81.00
timestamp: Thu Dec 28 18:34:55 2023, metric_value: 78.00
timestamp: Wed Dec 27 18:13:18 2023, metric_value: 101.00
timestamp: Tue Dec 26 18:13:27 2023, metric_value: 95.00
timestamp: Mon Dec 25 18:15:10 2023, metric_value: 85.00

@github-actions github-actions bot added awaiting triage perf-alert Automatically filed performance-related alerts. labels Jan 6, 2024
@AnandInguva
Copy link
Contributor

#29943 and #29944 seems to way random in values. I think these tests are not adding any value in determining a performance regression.

I think we should remove these tests from the perf test config file.

@damccorm
Copy link
Contributor

damccorm commented Jan 9, 2024

@AnandInguva it seems like outside of this one anomaly (which I'm guessing was bad hardware or something and is pretty easy to discard) this has been pretty stable - my vote would be to close/ignore this issue but leave the tests

@github-actions github-actions bot added this to the 2.54.0 Release milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage perf-alert Automatically filed performance-related alerts.
Projects
None yet
Development

No branches or pull requests

2 participants