Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Usage of logical types breaks Beam YAML Sql #29825

Closed
1 of 16 tasks
robertwb opened this issue Dec 19, 2023 · 3 comments · Fixed by #29826
Closed
1 of 16 tasks

[Bug]: Usage of logical types breaks Beam YAML Sql #29825

robertwb opened this issue Dec 19, 2023 · 3 comments · Fixed by #29826
Labels
awaiting triage bug P1 yaml
Milestone
2.54.0 Release

Comments

@robertwb
Copy link
Contributor

What happened?

Though schema transforms are generally preferred, this doesn't work for SqlTransform as its config schema uses java-only logical types.

This is a specific case of #29824

Issue Priority

Priority: 1 (data loss / total loss of function)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@robertwb robertwb added this to the 2.53.0 Release milestone Dec 19, 2023
@robertwb robertwb mentioned this issue Dec 19, 2023
Merged
3 tasks
@robertwb
Copy link
Contributor Author

Re-opening until change is cherry-picked into the release.

@robertwb robertwb reopened this Dec 20, 2023
@robertwb robertwb mentioned this issue Dec 20, 2023
Merged
3 tasks
@lostluck
Copy link
Contributor

There's one week until the 2.54.0 cut and this issue is tagged for that release, if possible/necessary please complete the necessary work before then, or move this to the 2.55.0 Release Milestone.

@Abacn
Copy link
Contributor

Abacn commented Jan 19, 2024

This one sounds already done in 2.53.0 release. 2.54.0 milestone is an effect of close and then re-open this after 2.53.0 cut

@Abacn Abacn closed this as completed Jan 19, 2024
@Abacn Abacn modified the milestones: 2.54.0 Release, 2.53.0 Release Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting triage bug P1 yaml
Projects
None yet
Milestone
2.54.0 Release
Development

Successfully merging a pull request may close this issue.

Revert to non-schema-based Sql transform. robertwb/incubator-beam
3 participants
@robertwb @Abacn @lostluck