Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ClickhouseIOWriter doesn't support Boolean #29087

Closed
1 of 16 tasks
rthneha opened this issue Oct 20, 2023 · 4 comments
Closed
1 of 16 tasks

[Bug]: ClickhouseIOWriter doesn't support Boolean #29087

rthneha opened this issue Oct 20, 2023 · 4 comments

Comments

@rthneha
Copy link

rthneha commented Oct 20, 2023

What happened?

Apache Beam supports Boolean Datatype read.
https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/schemas/Schema.FieldType.html

But ClickhouseIOWriter class doesn't support it.
https://github.com/apache/beam/blob/master/sdks/java/io/clickhouse/src/main/java/org/apache/beam/sdk/io/clickhouse/ClickHouseWriter.java

We can add Boolean support for it by doing below changes maybe:

  case BOOL:
    BinaryStreamUtils.writeUInt8(stream, (Boolean) value);
    break;  

Issue Priority

Priority: 3 (minor)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@mzitnik
Copy link
Contributor

mzitnik commented Nov 22, 2023

@rthneha Hi, I'm from ClickHouse i can handle the addition of bool type. Do we know any other types that we want to add as well.

@mshustov
Copy link

Boolean type has been added in #29522, should we close the issue?

@github-actions github-actions bot added this to the 2.53.0 Release milestone Nov 27, 2023
@priteshgudge
Copy link

Hi, I'm from ClickHouse i can handle the addition of bool type. Do we know any other types that we want to add as well.

@mzitnik Can we add support for Decimal32, Decimal64 and DateTime64 as well?

Should I add a new Issue to track this?

@mshustov
Copy link

mshustov commented Dec 7, 2023

@priteshgudge yes, please do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants