Add 'release/trigger_all_tests.json' to trigger path of mass comment PR #29064
Conversation
* Create GItHub Action PreCommit * Create missing Google-ads IO PreCommit * Create missing RequestResponse IO PreCommit
| - name: run goPreCommit script | ||
| uses: ./.github/actions/gradle-command-self-hosted-action | ||
| with: | ||
| gradle-command: :beam-test-gha:preCommit |
There was a problem hiding this comment.
./gradlew :beam-test-gha:preCommit passed locally
|
R: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Code looks good. |
Yeah that's the main benefits
|
Codecov Report
@@ Coverage Diff @@
## master #29064 +/- ##
==========================================
- Coverage 38.39% 38.39% -0.01%
==========================================
Files 686 686
Lines 101640 101646 +6
==========================================
Hits 39028 39028
- Misses 61032 61038 +6
Partials 1580 1580
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| github.event_name == 'pull_request_target' || | ||
| github.event_name == 'schedule' || | ||
| github.event_name == 'workflow_dispatch' || | ||
| github.event.comment.body == 'Run Go PreCommit' |
There was a problem hiding this comment.
This needs to be Run GHA PreCommit
Co-authored-by: Danny McCormick <[email protected]>
…PR (apache#29064) * Add 'release/trigger_all_tests.json' to trigger path of mass comment PR * Create GItHub Action PreCommit * Create missing Google-ads IO PreCommit * Create missing RequestResponse IO PreCommit * fix leftover * Fix leftover in phrase * Update contributor-docs/release-guide.md Co-authored-by: Danny McCormick <[email protected]> --------- Co-authored-by: Danny McCormick <[email protected]>
This replaces the mass comment workflow for release verification. Currently add all precommit to it.
Create GItHub Action PreCommit
Create missing Google-ads IO PreCommit
Create missing RequestResponse IO PreCommit
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.