Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML] Schema-producing Create. #29030

Merged
merged 2 commits into from
Oct 24, 2023
Merged

[YAML] Schema-producing Create. #29030

merged 2 commits into from
Oct 24, 2023

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Oct 16, 2023

Yaml's Create will now always create schema'd data. For non-row elements, this will be a single Row with an element field.

This brings increased consistency to the YAML API.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Yaml's Create will now always create schema'd data.
For non-row elements, this will be a single Row with an element field.
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #29030 (62f2576) into master (e7a6405) will decrease coverage by 0.03%.
Report is 25 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #29030      +/-   ##
==========================================
- Coverage   38.39%   38.36%   -0.03%     
==========================================
  Files         686      686              
  Lines      101651   101673      +22     
==========================================
- Hits        39025    39009      -16     
- Misses      61042    61089      +47     
+ Partials     1584     1575       -9     
Flag Coverage Δ
python 29.98% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/yaml/yaml_provider.py 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@liferoad
Copy link
Collaborator

LGTM. Not sure why some pre-commits keep failing.

@robertwb robertwb merged commit 3f05945 into apache:master Oct 24, 2023
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants