Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-cache-dir to tox install #29024

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Oct 16, 2023

Take a look at #29022


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Oct 16, 2023
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm notice that python precommits are not triggered on GHA. As a follow up we should add BeamModulePlugin.groovy to python precommit trigger paths. For now one way to trigger this jobs on GHA is to touch a python src file in this PR

@Abacn
Copy link
Contributor

Abacn commented Oct 16, 2023

Run Whitespace PreCommit

https://github.com/apache/beam/actions/runs/6539119070

#29022 affected this workflow on master: https://github.com/apache/beam/actions/runs/6537456915/job/17751339844 and seems resolved here.

@Abacn
Copy link
Contributor

Abacn commented Oct 16, 2023

Run Python PreCommit

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions bot added python and removed python labels Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #29024 (4b533f6) into master (75508e5) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #29024      +/-   ##
==========================================
- Coverage   38.40%   38.39%   -0.01%     
==========================================
  Files         686      686              
  Lines      101610   101629      +19     
==========================================
  Hits        39021    39021              
- Misses      61010    61029      +19     
  Partials     1579     1579              
Flag Coverage Δ
python 30.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/ml/transforms/base.py 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnandInguva AnandInguva merged commit a6917d4 into apache:master Oct 16, 2023
80 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants