[yaml] support gcs location for main.py yaml input file #29014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Kinard <[email protected]>
|
R: @robertwb |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #29014 +/- ##
==========================================
- Coverage 38.39% 38.38% -0.02%
==========================================
Files 686 686
Lines 101624 101654 +30
==========================================
- Hits 39018 39017 -1
- Misses 61026 61057 +31
Partials 1580 1580
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
robertwb
reviewed
Oct 18, 2023
| @@ -43,8 +44,8 @@ def _pipeline_spec_from_args(known_args): | |||
| raise ValueError( | |||
| "Exactly one of pipeline_spec or pipeline_spec_file must be set.") | |||
| elif known_args.pipeline_spec_file: | |||
| with open(known_args.pipeline_spec_file) as fin: | |||
There was a problem hiding this comment.
I think we still want to use the with syntax to make sure it gets closed properly.
Signed-off-by: Jeffrey Kinard <[email protected]>
robertwb
approved these changes
Oct 20, 2023
kkdoon
pushed a commit
to twitter-forks/beam
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying a GCS YAML file when running
main.pyi.e.
python -m apache_beam.yaml.main --pipeline_spec_file="gs://path/to/yaml/file"Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.