Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding metrics report #29010

Merged
merged 4 commits into from
Oct 24, 2023
Merged

adding metrics report #29010

merged 4 commits into from
Oct 24, 2023

Conversation

volatilemolotov
Copy link
Contributor

Adds metrics report to GH actions.

Waiting on approval for the mail action.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Oct 16, 2023
Copy link
Collaborator

@andreydevyatkin andreydevyatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comments

.github/workflows/beam_Metrics_Report.yml Outdated Show resolved Hide resolved
.github/workflows/beam_Metrics_Report.yml Outdated Show resolved Hide resolved
.github/workflows/beam_Metrics_Report.yml Outdated Show resolved Hide resolved
.github/workflows/beam_Metrics_Report.yml Show resolved Hide resolved
.github/workflows/beam_Metrics_Report.yml Outdated Show resolved Hide resolved
.github/workflows/beam_Metrics_Report.yml Outdated Show resolved Hide resolved
.github/workflows/beam_Metrics_Report.yml Outdated Show resolved Hide resolved
Comment on lines +112 to +113
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that we need to send a copy.
Can we specify the actual to? If no what is the next step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are specifying both to: and cc: in this case. This is temporary so that it can be tested once merged and action is approved (notice that only wokflow_dispatch trigger is enabled for now). After that there will be only to: dev@...

volatilemolotov and others added 2 commits October 16, 2023 21:39
Comment on lines 81 to 84
- name: Install Python
uses: actions/setup-python@v4
with:
python-version: 3.8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use setup-environment-action instead?

Suggested change
- name: Install Python
uses: actions/setup-python@v4
with:
python-version: 3.8
- name: Setup environment
uses: ./.github/actions/setup-environment-action
with:
python-version: 3.8

Copy link
Collaborator

@andreydevyatkin andreydevyatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@volatilemolotov volatilemolotov marked this pull request as ready for review October 17, 2023 13:41
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor

This should work once https://issues.apache.org/jira/browse/INFRA-25086 (not world visible) is resolved. Infra had some questions about the usage of the action, thus the delay

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action has been allowlisted

@damccorm damccorm merged commit 9e21f3d into apache:master Oct 24, 2023
3 checks passed
@volatilemolotov volatilemolotov deleted the metrics_report branch October 24, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants