Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing notebooks to prepare for DevSite import #28949

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

rszper
Copy link
Contributor

@rszper rszper commented Oct 11, 2023

Editing RunInference notebooks to prepare for DevSite import

R: @damccorm
R: @AnandInguva


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

"!git clone https://github.com/apache/beam\n",
"!pip install -r beam/sdks/python/build-requirements.txt\n",
"!pip install -e ./beam/sdks/python[gcp]\n",
"!pip install apache_beam[gcp]>=2.51.0 --quiet\n",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnandInguva @damccorm I'm planning to merge this after the 2.51.0 release, so this section needs to be updated, but please check to see if I updated it correctly. Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I actually had a pr open to do this already (and it is now merged - #28801)

@rszper
Copy link
Contributor Author

rszper commented Oct 11, 2023

R: @damccorm
R: @AnandInguva

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 7449b67 into apache:master Oct 12, 2023
2 checks passed
damondouglas pushed a commit to damondouglas/beam that referenced this pull request Oct 16, 2023
@rszper rszper deleted the rszper-notebookEdits-Oct23 branch October 16, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants