Fix watch_file_pattern condition in RunInference
#28948
Conversation
|
R: @damccorm We missed this bug. I was running a pipeline with auto model refresh and found this now. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28948 +/- ##
===========================================
- Coverage 72.15% 38.39% -33.76%
===========================================
Files 686 686
Lines 101590 101608 +18
===========================================
- Hits 73301 39012 -34289
- Misses 26713 61018 +34305
- Partials 1576 1578 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 313 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -1131,7 +1131,7 @@ def expand( | |||
| self._inference_args, | |||
| beam.pvalue.AsSingleton( | |||
| self._model_metadata_pcoll, | |||
| ) if self._enable_side_input_loading else None).with_resource_hints( | |||
| ) if self._model_metadata_pcoll else None).with_resource_hints( | |||
There was a problem hiding this comment.
_enable_side_input_loading is used elsewhere; can we update those references as well? Might make sense to remove it as a class variable and just make it a local variable that we can use in expand
|
Run Python_Coverage PreCommit |
* Fix bug for watch_file_pattern * Add fix to CHANGES.md * Remove _enable_side_input_loading flag * Add tests
watch_file_patternarg, even if mentioned in the RunInference had no affect. This PR fixes it.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.