Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counter for MLTransform and data processing transforms #28927

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

AnandInguva
Copy link
Contributor

Adds counters to the MLTransform and data processing transforms.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@AnandInguva AnandInguva marked this pull request as ready for review October 10, 2023 19:50
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #28927 (c064082) into master (e130352) will decrease coverage by 0.02%.
Report is 8 commits behind head on master.
The diff coverage is 26.31%.

@@            Coverage Diff             @@
##           master   #28927      +/-   ##
==========================================
- Coverage   72.16%   72.15%   -0.02%     
==========================================
  Files         686      686              
  Lines      101554   101573      +19     
==========================================
+ Hits        73291    73292       +1     
- Misses      26684    26702      +18     
  Partials     1579     1579              
Flag Coverage Δ
python 82.59% <26.31%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/ml/transforms/base.py 49.38% <26.31%> (-7.07%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@riteshghorse
Copy link
Contributor

Run Portable_Python PreCommit

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

sdks/python/apache_beam/ml/transforms/base.py Show resolved Hide resolved
@riteshghorse
Copy link
Contributor

Run Python_PVR_Flink PreCommit

@AnandInguva AnandInguva merged commit 2bd23b1 into apache:master Oct 11, 2023
76 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants