Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sourceJar task dependencies #28900

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix sourceJar task dependencies #28900

merged 1 commit into from
Oct 10, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 9, 2023

Fixes #28898

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Oct 9, 2023

Run Gradle Publish

@Abacn
Copy link
Contributor Author

Abacn commented Oct 9, 2023

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #28900 (39dfd84) into master (21f822f) will increase coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is 60.86%.

❗ Current head 39dfd84 differs from pull request most recent head 708fbf1. Consider uploading reports for the commit 708fbf1 to get more accurate results

@@            Coverage Diff             @@
##           master   #28900      +/-   ##
==========================================
+ Coverage   72.16%   72.18%   +0.02%     
==========================================
  Files         686      686              
  Lines      101551   101562      +11     
==========================================
+ Hits        73283    73313      +30     
+ Misses      26690    26671      -19     
  Partials     1578     1578              
Flag Coverage Δ
python 82.65% <60.86%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/pipeline.py 91.75% <85.71%> (-0.10%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.77% <50.00%> (-0.46%) ⬇️
sdks/python/apache_beam/transforms/display.py 92.20% <75.00%> (-1.17%) ⬇️
sdks/python/apache_beam/yaml/main.py 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abacn Abacn marked this pull request as ready for review October 9, 2023 20:57
@Abacn
Copy link
Contributor Author

Abacn commented Oct 9, 2023

R: @ahmedabu98

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround! LGTM when tests pass

@Abacn
Copy link
Contributor Author

Abacn commented Oct 9, 2023

Run Gradle Publish

@ahmedabu98
Copy link
Contributor

Run Java_Pulsar_IO_Direct PreCommit

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98
Copy link
Contributor

Run Portable_Python PreCommit

@ahmedabu98
Copy link
Contributor

Run Python_PVR_Flink PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Oct 10, 2023

Run Java PreCommit

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn Abacn merged commit 3d574b4 into apache:master Oct 10, 2023
31 of 32 checks passed
@Abacn Abacn deleted the fixSourceJar branch October 10, 2023 14:18
@Abacn Abacn mentioned this pull request Oct 10, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Nightly snapshot release is failing due to Gradle 8 upgrade
2 participants