We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProtoCoder can't encode messages that are above the Integer.MAX_VALUE bytes (2.147483647gb). This is due to the following https://github.com/protocolbuffers/protobuf/blob/d41b9e7a4b2834572cc396c41809fd46ea5eb5d4/java/core/src/main/java/com/google/protobuf/MessageLite.java#L55 can return negative. It seems like there are a lot of undefined behaviors when there are protobuf this large.
2.147483647gb
However, it at least seems that ProtoEncoder can check the size and writeDelimited to the output stream to solve this in this method
beam/sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoCoder.java
Line 190 in b876299
Naturally, no one should probably have protobuf's this large anyways, but here I am!
Priority: 2 (default / most bugs should be filed as P2)
The text was updated successfully, but these errors were encountered:
cc @robertwb @kennknowles
Sorry, something went wrong.
@snallapa want to contribute the fix? 😄 😄 😄
@kennknowles if I find the time in the next week or so I will try to!
No branches or pull requests
What happened?
ProtoCoder can't encode messages that are above the Integer.MAX_VALUE bytes (
2.147483647gb
). This is due to the following https://github.com/protocolbuffers/protobuf/blob/d41b9e7a4b2834572cc396c41809fd46ea5eb5d4/java/core/src/main/java/com/google/protobuf/MessageLite.java#L55 can return negative. It seems like there are a lot of undefined behaviors when there are protobuf this large.However, it at least seems that ProtoEncoder can check the size and writeDelimited to the output stream to solve this in this method
beam/sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoCoder.java
Line 190 in b876299
Naturally, no one should probably have protobuf's this large anyways, but here I am!
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components
The text was updated successfully, but these errors were encountered: