Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace precommit after gradle 8 #28845

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 5, 2023

Fixes #28756 (comment)

  • exclude intermediate build directory. Specifically /beam/build/

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Oct 5, 2023
@Abacn
Copy link
Contributor Author

Abacn commented Oct 5, 2023

It failed on gradle 8 because the zip src folder includes the python virtualenv folder, explicitly set here (was a workaround of gradle gc behavior):


in general we should not include gradle intermediate dir **/build/**

It failed locally for different reason. Beam repo linked to google/docsy : https://github.com/apache/beam/tree/master/website/www/site/themes

For some reason this file is present locally but not on GHA / Jenkins (previously)

@Abacn
Copy link
Contributor Author

Abacn commented Oct 5, 2023

Run Whitespace PreCommit

test passed: https://github.com/apache/beam/actions/runs/6419609343/job/17429832396

@Abacn Abacn marked this pull request as ready for review October 5, 2023 13:23
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #28845 (8c2600e) into master (161cd6b) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28845      +/-   ##
==========================================
- Coverage   72.22%   72.21%   -0.01%     
==========================================
  Files         684      684              
  Lines      101230   101230              
==========================================
- Hits        73110    73106       -4     
- Misses      26545    26549       +4     
  Partials     1575     1575              
Flag Coverage Δ
python 82.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abacn
Copy link
Contributor Author

Abacn commented Oct 5, 2023

python coverage passed on GHA

@Abacn Abacn merged commit c89d44d into apache:master Oct 5, 2023
78 checks passed
@Abacn Abacn deleted the fixwhitespace branch October 5, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants