Add observed=False to be explicit for Pandas 2.1 #28823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @tvalentyn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Run Python_Coverage PreCommit |
Codecov Report
@@ Coverage Diff @@
## master #28823 +/- ##
==========================================
- Coverage 72.24% 72.21% -0.03%
==========================================
Files 684 684
Lines 101230 101230
==========================================
- Hits 73133 73105 -28
- Misses 26521 26549 +28
Partials 1576 1576
Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Run Python_PVR_Flink PreCommit |
tvalentyn
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Pandas 2.1, observed=False is deprecated as the default for groupby, and raises warnings when grouping on categoricals. Explicitly set observed=False in these tests to stop that.