Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily Ignore 2 FhirIO Integration Tests #28717

Merged
merged 15 commits into from
Oct 2, 2023

Conversation

svetakvsundhar
Copy link
Contributor

@svetakvsundhar svetakvsundhar commented Sep 28, 2023

Temporarily disabling due to #28635, #28505.

Will enable once Jenkins to GHA migration is complete.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@svetakvsundhar svetakvsundhar marked this pull request as draft September 28, 2023 15:05
@svetakvsundhar
Copy link
Contributor Author

retest this please

@svetakvsundhar svetakvsundhar changed the title Fix GC Error for FhirIO Integration Tests Temporarily Ignore 2 FhirIO Integration Tests Sep 28, 2023
@svetakvsundhar svetakvsundhar marked this pull request as ready for review September 28, 2023 18:33
@svetakvsundhar
Copy link
Contributor Author

r: @bvolpato

I think it's worth disabling these for now, and then seeing what we have to work with once the migration is complete.

@svetakvsundhar svetakvsundhar marked this pull request as draft September 28, 2023 18:35
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@bvolpato
Copy link
Contributor

Thanks! Missed an import

/runner/_work/beam/beam/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIOSearchIT.java:159: error: cannot find symbol
  @Ignore("https://github.com/apache/beam/issues/28505")
   ^
  symbol:   class Ignore
  location: class FhirIOSearchIT

@svetakvsundhar
Copy link
Contributor Author

yes, sorry, pushing in next commit

@svetakvsundhar svetakvsundhar marked this pull request as ready for review September 28, 2023 18:38
@svetakvsundhar
Copy link
Contributor Author

retest this please

@svetakvsundhar
Copy link
Contributor Author

R: @ahmedabu98

@svetakvsundhar
Copy link
Contributor Author

Run Java_GCP_IO_Direct PreCommit

@kennknowles kennknowles merged commit f2194f6 into apache:master Oct 2, 2023
32 of 34 checks passed
@svetakvsundhar svetakvsundhar deleted the 28635 branch October 2, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants