Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom MetricsFetcher in Perf tooling. #28671

Merged
merged 14 commits into from
Oct 5, 2023

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Sep 26, 2023

Fixes: #28668

  • Add MetricsFetcher class where anyone can inherit from it, build a Custom metrics_fetcher and pass it to the perf_analuysis.run()

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #28671 (5d35e4e) into master (e328ab5) will increase coverage by 0.24%.
Report is 70 commits behind head on master.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master   #28671      +/-   ##
==========================================
+ Coverage   71.96%   72.20%   +0.24%     
==========================================
  Files         680      684       +4     
  Lines      100172   101233    +1061     
==========================================
+ Hits        72088    73099    +1011     
- Misses      26509    26559      +50     
  Partials     1575     1575              
Flag Coverage Δ
python 82.74% <14.28%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...beam/testing/load_tests/load_test_metrics_utils.py 33.44% <ø> (-0.45%) ⬇️
...ache_beam/testing/analyzers/github_issues_utils.py 40.90% <28.57%> (-1.95%) ⬇️
...hon/apache_beam/testing/analyzers/perf_analysis.py 15.71% <11.11%> (-1.19%) ⬇️
...ache_beam/testing/analyzers/perf_analysis_utils.py 19.58% <10.52%> (-2.01%) ⬇️

... and 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the build label Sep 28, 2023
@AnandInguva
Copy link
Contributor Author

R: @pranavbhandari24

@AnandInguva AnandInguva marked this pull request as ready for review September 29, 2023 00:13
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@AnandInguva
Copy link
Contributor Author

@pranavbhandari24 any update?

@liferoad
Copy link
Collaborator

liferoad commented Oct 3, 2023

@Abacn @damondouglas FYI.

Copy link
Contributor

@pranavbhandari24 pranavbhandari24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anand! Overall LGTM, just a couple concerns

please follow the below structure.

**NOTE**: The Change point analysis only supports reading the metric data from Big Query for now.
**NOTE**: The Change point analysis only supports reading the metric data from `BigQuery` only.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: only is repeated, we can omit it from the end of the sentence


for test_name, params in tests_config.items():
for test_id, params in tests_config.items():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had spoken about supporting multiple metric_name for a single test_id. These metric names will be provided as a list in the config.
Shouldn't we check if params['metric_name'] is a list and execute run_change_point_analysis for each metric_name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done by adding metric_name as a parameter to run_change_point_analysis instead of accessing it directly in the method?

I'll defer to your opinion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, passing metrics as list will be implemented in a different PR. I will tag you there once it is ready.

@AnandInguva AnandInguva merged commit 5446776 into apache:master Oct 5, 2023
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Support custom BQ schema for perf alert tool
3 participants