Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require --sdk_location for Dataflow pipelines running with dev SDKs. #28670

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Sep 26, 2023

Beam Dev SDK containers also include Beam SDK, which might be not the same as what users have locally when they submit a Dataflow pipeline. Provide an explicit error to make sure pipelines running with Dev SDKs supply an SDK location.

This was already a requirement before we switched to use external containers.

@tvalentyn
Copy link
Contributor Author

Run Portable_Python PreCommit

@tvalentyn
Copy link
Contributor Author

Run Python 3.8 PostCommit

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #28670 (c1d13e3) into master (adb1a94) will decrease coverage by 0.25%.
Report is 19 commits behind head on master.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #28670      +/-   ##
==========================================
- Coverage   72.20%   71.95%   -0.25%     
==========================================
  Files         684      680       -4     
  Lines      101141   100166     -975     
==========================================
- Hits        73025    72079     -946     
+ Misses      26540    26511      -29     
  Partials     1576     1576              
Flag Coverage Δ
python 82.53% <66.66%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/python/apache_beam/runners/portability/stager.py 84.39% <ø> (ø)
...on/apache_beam/runners/dataflow/dataflow_runner.py 81.15% <66.66%> (+0.14%) ⬆️

... and 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvalentyn tvalentyn changed the title Remove experimental phrasing around extra packages. Require --sdk_location for Dataflow pipelines running with dev SDKs. Sep 27, 2023
@tvalentyn tvalentyn marked this pull request as ready for review September 27, 2023 17:39
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvalentyn tvalentyn merged commit ced3de3 into apache:master Sep 27, 2023
76 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants