Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync it framework BigtableResourceManager #28588

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 21, 2023

Fix breakage caused by #28541 while trying to fix checkStyle error

Replicates GoogleCloudPlatform/DataflowTemplates#1066

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Sep 21, 2023

R: @bvolpato

@Abacn Abacn added this to the 2.51.0 Release milestone Sep 21, 2023
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor Author

Abacn commented Sep 21, 2023

R: @pranavbhandari24

Copy link
Contributor

@pranavbhandari24 pranavbhandari24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abacn Abacn merged commit 94327fd into apache:master Sep 21, 2023
4 checks passed
@Abacn Abacn deleted the fixsyncit branch September 21, 2023 17:28
Abacn added a commit to Abacn/beam that referenced this pull request Sep 21, 2023
kennknowles added a commit that referenced this pull request Sep 22, 2023
…ync it framework BigtableResourceManager
kennknowles pushed a commit to kennknowles/beam that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants